This repository was archived by the owner on Dec 4, 2017. It is now read-only.
Fix display of heritage #2792
Merged
Fix display of heritage #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxandxss
approved these changes
Nov 12, 2016
|
That was quick @Foxandxss |
|
I'm impressed by the response time here (for the and fix and for the review) ! |
|
Why haven't we merged this yet? I don't know enough about it to do it (except to blindly click the button) |
|
Merged on Pete's request to me in Slack on Dec 14 |
|
I'm less impressed by the response time now :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to fixing the problem that classes like
Responsein@angular/httpdoes not show that it derives fromBody. A heritage string is already extracted by thetypescriptdgeni-package. So this PR includes this information in the relevant templates for classes and interface.But this is probably not enough since these super types are not explicitly exported from any modules and so there are no API docs pages for them.
Closes #2791